Skip to content

Backports to v1.12 #1490

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Nov 28, 2025
Merged

Backports to v1.12 #1490

merged 5 commits into from
Nov 28, 2025
+44 −51

Conversation

@dkarrasch
Copy link
Member

@dkarrasch dkarrasch commented Nov 26, 2025 •
edited
Loading

@codecov
Copy link

codecov bot commented Nov 26, 2025 •
edited
Loading

Codecov Report

❌ Patch coverage is 66.66667% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 93.63%. Comparing base (5567504) to head (b17cd17).
⚠️ Report is 6 commits behind head on release-1.12.

Files with missing lines Patch % Lines
src/triangular.jl 42.85% 4 Missing ⚠️
src/hessenberg.jl 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@               Coverage Diff                @@
##           release-1.12    #1490      +/-   ##
================================================
+ Coverage         93.56%   93.63%   +0.06%     
================================================
  Files                34       34              
  Lines             15487    15481       -6     
================================================
+ Hits              14490    14495       +5     
+ Misses              997      986      -11

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@dkarrasch
Copy link
Member Author

dkarrasch commented Nov 27, 2025

Why can't I make a merge commit? It only offers "Squash and merge", but we don't squash backports commits, do we?

@KristofferC @ViralBShah

@dkarrasch dkarrasch merged commit 997c4b7 into release-1.12 Nov 28, 2025
3 of 4 checks passed
@dkarrasch dkarrasch deleted the backports-release-1.12 branch November 28, 2025 08:35
@ViralBShah
Copy link
Member

ViralBShah commented Nov 28, 2025

I personally have no view on it - if useful, we can turn them on. I am not sure how they interact with the rest of our processes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@dkarrasch @ViralBShah @bertini97 @Technici4n